Don't show the Location Settings Dialog if the tab isn't interactable.

chrome/browser/geolocation/geolocation_permission_context_android.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context_android.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/feature_list.h"
 #include "base/metrics/histogram_functions.h"
 #include "chrome/browser/android/location_settings.h"
 #include "chrome/browser/android/location_settings_impl.h"
 #include "chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h"
 #include "chrome/browser/android/search_geolocation/search_geolocation_service.h"
 #include "chrome/browser/permissions/permission_request_id.h"
 #include "chrome/browser/permissions/permission_update_infobar_delegate_android.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
+#include "chrome/browser/ui/android/tab_model/tab_model.h"
+#include "chrome/browser/ui/android/tab_model/tab_model_list.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/pref_names.h"
 #include "components/infobars/core/infobar.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 #include "components/search_engines/template_url.h"
 #include "components/search_engines/template_url_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 199 matching lines @@
       return;
     }
 
     LogLocationSettingsMetric(kLocationSettingsShowMetricBase,
                               is_default_search,
                               LocationSettingsBackOffLevel(is_default_search));
     content::WebContents* web_contents =
         content::WebContents::FromRenderFrameHost(
             content::RenderFrameHost::FromID(id.render_process_id(),
                                              id.render_frame_id()));
+
+    // Only show the location settings dialog if the current tab is for
+    // |web_contents|. Note, the TabModel will be null in unit tests.
+    TabModel* tab_model = TabModelList::GetTabModelForWebContents(web_contents);
+    if (tab_model && tab_model->GetActiveWebContents() != web_contents) {

[Ted C, 2017/04/13 15:47:08]

I wonder if this should be !tab_model ||

Though that might break things if we were ever to enable location requesting in
panels like contextual search where it isn't associated with a model.

Keep it as is, I wonder if we should add something like
!web_contents->IsHidden() or something to capture other cases?

We also added TabAndroid::IsUserInteractable to handle cases where you are in
the tab switcher where we wouldn't necessarily want to popup stuff either.  We
likely could use that call instead of the tab model if we wanted to be a bit
more restrictive.

[benwells, 2017/04/14 00:13:53]

It was like this originally, but it broke some tests that have a null tab model.
I think that's a good idea. I'll poke with that next week. Another case to
handle is that Chrome isn't the active application ... I was going to handle
that on the Java side but maybe IsUserInteractable or / or IsHidden can do it
instead.

+      FinishNotifyPermissionSet(id, requesting_origin, embedding_origin,
+                                callback, false /* persist */,
+                                CONTENT_SETTING_BLOCK);
+      // This case should be very rare, so just pretend it was a denied prompt
+      // for metrics purposes.
+      LogLocationSettingsMetric(
+          kLocationSettingsDenyMetricBase, is_default_search,
+          LocationSettingsBackOffLevel(is_default_search));
+      return;
+    }
+
     location_settings_->PromptToEnableSystemLocationSetting(
         is_default_search ? SEARCH : DEFAULT, web_contents,
         base::BindOnce(
             &GeolocationPermissionContextAndroid::OnLocationSettingsDialogShown,
             weak_factory_.GetWeakPtr(), id, requesting_origin, embedding_origin,
             callback, persist, content_setting));
     return;
   }
 
   FinishNotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
@@ skipping 235 matching lines @@
     // The tab helper can be null in tests.
     if (disclosure_helper)
       disclosure_helper->MaybeShowDisclosure(requesting_origin);
   }
 }
 
 void GeolocationPermissionContextAndroid::SetLocationSettingsForTesting(
     std::unique_ptr<LocationSettings> settings) {
   location_settings_ = std::move(settings);
 }