Issue 281783004: Revert 270226 "Componentize GCM Part 1: create GCM component and..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 281783004: Revert 270226 "Componentize GCM Part 1: create GCM component and..." (Closed)

Created:
6 years, 7 months ago by piman

Modified:
6 years, 7 months ago

Reviewers:
jianli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 270226 "Componentize GCM Part 1: create GCM component and..." broke on Chrome OS: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/67606 > Componentize GCM Part 1: create GCM component and move some files over > > BUG=356716 > TEST=existing tests > > Review URL: https://codereview.chromium.org/261853012 TBR=jianli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270234

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -404 lines)			Patch
M	trunk/src/chrome/browser/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/gcm/gcm_apitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_gcm_app_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/invalidation/gcm_invalidation_bridge.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	trunk/src/chrome/browser/services/gcm/default_gcm_app_handler.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/services/gcm/default_gcm_app_handler.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/fake_gcm_client_factory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	trunk/src/chrome/browser/services/gcm/gcm_app_handler.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/services/gcm/gcm_client_factory.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/services/gcm/gcm_client_factory.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/gcm_client_mock.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/gcm_client_mock.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/gcm_profile_service_factory.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/gcm_profile_service_factory.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/gcm_profile_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/gcm_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/gcm_service.cc	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/services/gcm/gcm_service_unittest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser.gypi	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	trunk/src/components/OWNERS	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/components/components.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	trunk/src/components/gcm_driver.gypi	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	trunk/src/components/gcm_driver/DEPS	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	trunk/src/components/gcm_driver/OWNERS	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	trunk/src/components/gcm_driver/default_gcm_app_handler.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	trunk/src/components/gcm_driver/default_gcm_app_handler.cc	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	trunk/src/components/gcm_driver/gcm_app_handler.h	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	trunk/src/components/gcm_driver/gcm_client_factory.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	trunk/src/components/gcm_driver/gcm_client_factory.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	trunk/src/components/gcm_driver/system_encryptor.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	trunk/src/components/gcm_driver/system_encryptor.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	trunk/src/google_apis/gcm/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	trunk/src/google_apis/gcm/base/encryptor.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	trunk/src/google_apis/gcm/base/fake_encryptor.h	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	trunk/src/google_apis/gcm/base/fake_encryptor.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/gcm_store_impl.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/gcm_store_impl.cc	View	6 chunks	+9 lines, -18 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/gcm_store_impl_unittest.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/mcs_client_unittest.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	trunk/src/google_apis/gcm/gcm.gyp	View	4 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/google_apis/gcm/gcm_client.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/google_apis/gcm/gcm_client_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/google_apis/gcm/gcm_client_impl.cc	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	trunk/src/google_apis/gcm/gcm_client_impl_unittest.cc	View	4 chunks	+9 lines, -2 lines	0 comments	Download
M	trunk/src/google_apis/gcm/tools/mcs_probe.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

piman

6 years, 7 months ago (2014-05-13 23:11:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r270234 (tree was closed).

Expand Messages | Collapse Messages