chrome/browser/notifications/non_persistent_notification_handler.cc - Issue 2817813006: Make progress notifications an alert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/non_persistent_notification_handler.cc

Issue 2817813006: Make progress notifications an alert. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/notifications/notification_platform_bridge_mac.mm » ('j') | chrome/browser/notifications/notification_platform_bridge_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/non_persistent_notification_handler.cc

diff --git a/chrome/browser/notifications/non_persistent_notification_handler.cc b/chrome/browser/notifications/non_persistent_notification_handler.cc

index e40b79ce2ff3b8c0a604be79cc1ecda96a1f5d79..84ec7804cbf902ee529a7b7d4f11a278c1b58641 100644

--- a/chrome/browser/notifications/non_persistent_notification_handler.cc

+++ b/chrome/browser/notifications/non_persistent_notification_handler.cc

@@ -42,7 +42,6 @@ void NonPersistentNotificationHandler::OpenSettings(Profile* profile) {

void NonPersistentNotificationHandler::RegisterNotification(

const std::string& notification_id,

NotificationDelegate* delegate) {

- DCHECK_EQ(notifications_.count(notification_id), 0u);

Peter Beverloo 2017/04/13 14:14:14 ohhh I guess this is invalid for replacements, rig

Miguel Garcia 2017/04/13 16:36:19 Acknowledged.

notifications_[notification_id] =

scoped_refptr<NotificationDelegate>(delegate);

}