chrome/browser/resources/settings/people_page/users_add_user_dialog.js - Issue 2817803002: MD Settings: CrOS: Focus elements on dialog close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/users_add_user_dialog.js

Issue 2817803002: MD Settings: CrOS: Focus elements on dialog close (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/network_siminfo.js ('K') | « chrome/browser/resources/settings/internet_page/network_siminfo.js ('k') | chrome/browser/resources/settings/printing_page/cups_printers.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/users_add_user_dialog.js

diff --git a/chrome/browser/resources/settings/people_page/users_add_user_dialog.js b/chrome/browser/resources/settings/people_page/users_add_user_dialog.js

index 99b274881848129cce5a173c2f5b6b0151ee6c46..a8b462c3805ea2f9331a5f4365b930cdf1184a02 100644

--- a/chrome/browser/resources/settings/people_page/users_add_user_dialog.js

+++ b/chrome/browser/resources/settings/people_page/users_add_user_dialog.js

@@ -40,7 +40,7 @@ Polymer({

- open: function() {

+ attached: function() {

dpapad 2017/04/13 00:16:40 I could not find any callers of open() in this CL

stevenjb 2017/04/13 00:39:09 Ugh, too many balls in the air. I started to conve

this.isValid_ = false;

this.$.dialog.showModal();