Chromium Code Reviews| Index: chrome/browser/resources/settings/internet_page/network_siminfo.html |
| diff --git a/chrome/browser/resources/settings/internet_page/network_siminfo.html b/chrome/browser/resources/settings/internet_page/network_siminfo.html |
| index 212a63a5befc9a7d1bee7679594586b9aeff5a6b..d300cf8361a1700cfb10df12781b337858ecc6ca 100644 |
| --- a/chrome/browser/resources/settings/internet_page/network_siminfo.html |
| +++ b/chrome/browser/resources/settings/internet_page/network_siminfo.html |
| @@ -67,7 +67,7 @@ |
| <div class="error">$i18n{networkSimCardLocked}</div> |
| </div> |
| <div class="secondary-action"> |
| - <paper-button on-tap="onUnlockPinTap_"> |
| + <paper-button id="unlockPinButton" on-tap="onUnlockPinTap_"> |
|
dpapad
2017/04/13 00:16:40
Is the "Button" suffix necessary for disambiguatio
stevenjb
2017/04/13 00:39:09
There is already a paper-input "unlockPin". I'd re
|
| $i18n{networkSimUnlock} |
| </paper-button> |
| </div> |
| @@ -79,18 +79,20 @@ |
| <div id="simLockToggleLabel" class="start"> |
| $i18n{networkSimLockEnable} |
| </div> |
| - <paper-button on-tap="onChangePinTap_" |
| + <paper-button id="changePinButton" on-tap="onChangePinTap_" |
| hidden$="[[!networkProperties.Cellular.SIMLockStatus.LockEnabled]]"> |
| $i18n{networkSimChangePin} |
| </paper-button> |
| - <paper-toggle-button on-change="onSimLockEnabledChange_" |
| + <paper-toggle-button id="simLockButton" |
| + on-change="onSimLockEnabledChange_" |
| checked="[[networkProperties.Cellular.SIMLockStatus.LockEnabled]]" |
| aria-labelledby="simLockToggleLabel"> |
| </paper-toggle-button> |
| </div> |
| <!-- Enter PIN dialog --> |
| - <dialog is="cr-dialog" id="enterPinDialog" close-text="$i18n{close}"> |
| + <dialog is="cr-dialog" id="enterPinDialog" close-text="$i18n{close}" |
| + on-close="onEnterPinDialogClosed_"> |
| <div class="title">$i18n{networkSimEnterPinTitle}</div> |
| <div class="body"> |
| <paper-input id="enterPin" class="pin" no-label-float |
| @@ -110,7 +112,8 @@ |
| </dialog> |
| <!-- Change PIN dialog --> |
| - <dialog is="cr-dialog" id="changePinDialog" close-text="$i18n{close}"> |
| + <dialog is="cr-dialog" id="changePinDialog" close-text="$i18n{close}" |
| + on-close="onChangePinDialogClose_"> |
| <div class="title">$i18n{networkSimChangePinTitle}</div> |
| <div class="body"> |
| <paper-input id="changePinOld" class="pin" no-label-float |
| @@ -136,7 +139,8 @@ |
| </dialog> |
| <!-- Unlock PIN dialog --> |
| - <dialog is="cr-dialog" id="unlockPinDialog" close-text="$i18n{close}"> |
| + <dialog is="cr-dialog" id="unlockPinDialog" close-text="$i18n{close}" |
| + on-close="onUnlockPinDialogClose_"> |
| <div class="title">$i18n{networkSimLockedTitle}</div> |
| <div class="body"> |
| <paper-input id="unlockPin" class="pin" no-label-float |
| @@ -156,7 +160,8 @@ |
| </dialog> |
| <!-- Unlock PUK dialog --> |
| - <dialog is="cr-dialog" id="unlockPukDialog" close-text="$i18n{close}"> |
| + <dialog is="cr-dialog" id="unlockPukDialog" close-text="$i18n{close}" |
| + on-close="onUnlockPinDialogClose_"> |
| <div class="title">$i18n{networkSimLockedTitle}</div> |
| <div class="body"> |
| <div> |