Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 281773003: Use @SuppressLint in place of @TargetApi to suppress lint warnings for the inlined API. (Closed)

Created:
6 years, 7 months ago by Sungmann Cho
Modified:
6 years, 7 months ago
Reviewers:
Lambros, newt (away)
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use @SuppressLint in place of @TargetApi to suppress lint warnings for the inlined API. This is a follow up to https://codereview.chromium.org/273313003. Please refer to the discussion in the above link. BUG=327768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/Desktop.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Sungmann Cho
newt for review Lambros for approval Please take a look! Thanks!
6 years, 7 months ago (2014-05-14 03:02:51 UTC) #1
Sungmann Cho
ping...
6 years, 7 months ago (2014-05-16 06:54:46 UTC) #2
newt (away)
lgtm, thanks!
6 years, 7 months ago (2014-05-16 16:05:48 UTC) #3
Lambros
lgtm
6 years, 7 months ago (2014-05-16 16:57:49 UTC) #4
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-16 17:39:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/281773003/1
6 years, 7 months ago (2014-05-16 17:40:10 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 19:26:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 20:32:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27982)
6 years, 7 months ago (2014-05-16 20:32:04 UTC) #9
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-16 23:23:04 UTC) #10
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-16 23:23:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/281773003/1
6 years, 7 months ago (2014-05-16 23:32:25 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 15:42:42 UTC) #13
Message was sent while issue was closed.
Change committed as 271208

Powered by Google App Engine
This is Rietveld 408576698