content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 2817673003: Making Mac Dictionary better for OOPIFs and <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2817673003: Making Mac Dictionary better for OOPIFs and <webview> (Closed)

Patch Set: Remove ScopedBrowserClient Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index d32665cddf5c8df7a1a9988019ccf1cffe8314c8..263113a44902c9f2db46367887720c80c1fba973 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -560,6 +560,10 @@ void RenderWidgetHostViewChildFrame::SetActive(bool active) {

}

void RenderWidgetHostViewChildFrame::ShowDefinitionForSelection() {

+ if (frame_connector_) {

+ frame_connector_->GetRootRenderWidgetHostView()

+ ->ShowDefinitionForSelection();

+ }

}

bool RenderWidgetHostViewChildFrame::SupportsSpeech() const {