Rendering text on insecure-site warnings for WebVR

ui/gfx/BUILD.gn

Index: ui/gfx/BUILD.gn
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
index 595f3d021985175a377bea39585c8da36d26d8a8..744fd6561bc2484ba375f2e2c41a95e2fb9bafed 100644
--- a/ui/gfx/BUILD.gn
+++ b/ui/gfx/BUILD.gn
@@ -255,12 +255,13 @@ component("gfx") {
     "//base:base_static",
     "//base:i18n",
     "//base/third_party/dynamic_annotations",
+    "//device/vr:features",

[sadrul, 2017/04/21 22:31:47]

Actually, can you move this down, in (is_android && enable_vr) block?

[acondor_, 2017/04/24 14:28:21]

"features" is a header that defines ENABLE_VR, so it is in fact needed in all
platforms.

[sadrul, 2017/04/24 14:31:49]

I see. Maybe that header could move into an OS_ANDROID check?

Do you know whether/when we plan on supporting |enable_vr| on non-android
platforms? If it is on the plans, then this is ok. If not, some of the following
could also be simplified (e.g. 'is_android && enable_vr' could just be
'enable_vr')

     "//skia",
     "//third_party/zlib",
   ]
 
   # Text rendering conditions (complicated so separated out).
-  if (use_aura || is_mac) {
+  if (use_aura || is_mac || (is_android && enable_vr)) {
     # Mac doesn't use RenderTextHarfBuzz by default yet.
     sources += [
       "harfbuzz_font_skia.cc",
@@ -282,7 +283,7 @@ component("gfx") {
     # We don't support RenderText on these platforms.
   }
 
-  if (is_android && use_aura) {
+  if (is_android && enable_vr) {
     sources -= [
       "platform_font_android.cc",
       "text_utils_android.cc",
@@ -306,7 +307,7 @@ component("gfx") {
 
   # Android.
   if (is_android) {
-    if (use_aura) {
+    if (enable_vr) {
       sources -= [ "canvas_notimplemented.cc" ]
       sources += [ "font_fallback_android.cc" ]
     } else {