chrome/browser/android/vr_shell/vr_shell.cc - Issue 2817663003: Rendering text on insecure-site warnings for WebVR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/vr_shell.cc

Issue 2817663003: Rendering text on insecure-site warnings for WebVR (Closed)

Patch Set: Measuring text to accomplish a more proper layout and positioning icons according to RTL languages Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/vr_shell.cc

diff --git a/chrome/browser/android/vr_shell/vr_shell.cc b/chrome/browser/android/vr_shell/vr_shell.cc

index 76a71422222f2a3d6186e4e9625806e65d39d562..27713c8c8e223c83d35b52b478214a2bcff70074 100644

--- a/chrome/browser/android/vr_shell/vr_shell.cc

+++ b/chrome/browser/android/vr_shell/vr_shell.cc

@@ -452,6 +452,8 @@ void VrShell::ContentPhysicalBoundsChanged(JNIEnv* env,

jint height,

jfloat dpr) {

TRACE_EVENT0("gpu", "VrShell::ContentPhysicalBoundsChanged");

+ // TODO(acondor): Set the device scale factor for font rendering on the

+ // VR Shell textures.

PostToGlThreadWhenReady(base::Bind(&VrShellGl::ContentPhysicalBoundsChanged,

gl_thread_->GetVrShellGl(), width,

height));