Rendering text on insecure-site warnings for WebVR

ui/gfx/font_render_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_FONT_RENDER_PARAMS_H_
 #define UI_GFX_FONT_RENDER_PARAMS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 94 matching lines @@
 GFX_EXPORT FontRenderParams GetFontRenderParams(
     const FontRenderParamsQuery& query,
     std::string* family_out);
 
 #if defined(OS_LINUX)
 // Clears GetFontRenderParams()'s cache. Intended to be called by tests that are
 // changing Fontconfig's configuration.
 GFX_EXPORT void ClearFontRenderParamsCacheForTest();
 #endif
 
-#if defined(OS_CHROMEOS) || defined(OS_LINUX)
+#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_ANDROID)

[mthiesse, 2017/04/13 14:16:51]

You would need to also include ENABLE_VR here or you'll get compile errors when
ENABLE_VR is off.

[sadrul, 2017/04/13 14:57:55]

I think if you add ENABLE_VR, then you won't need OS_ANDROID?

[acondor_, 2017/04/18 20:59:04]

Added ENABLE_VR check. mthiesse, what are your thoughts on removing OS_ANDROID?

 // Gets the device scale factor to query the FontRenderParams.
 GFX_EXPORT float GetFontRenderParamsDeviceScaleFactor();
 
 // Sets the device scale factor for FontRenderParams to decide
 // if it should enable subpixel positioning.
 GFX_EXPORT void SetFontRenderParamsDeviceScaleFactor(

[sadrul, 2017/04/13 14:57:55]

It doesn't look like there's any android code that makes this call. So fonts
probably won't be using the right scale-factor I think, unless you add this call
from somewhere? (I am just pointing this out, you can add the code to set the
correct DSF in a separate CL)

[acondor_, 2017/04/18 20:59:04]

Thanks. Added a TODO for that on vr_shell.cc

     float device_scale_factor);
 #endif
 
 }  // namespace gfx
 
 #endif  // UI_GFX_FONT_RENDER_PARAMS_H_