Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: components/policy/core/common/cloud/user_cloud_policy_store_base.cc

Issue 2817643002: Make CloudPolicyValidator memory management clearer (Closed)
Patch Set: Cleaner memory management in CloudPolicyValidator Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/user_cloud_policy_store_base.cc
diff --git a/components/policy/core/common/cloud/user_cloud_policy_store_base.cc b/components/policy/core/common/cloud/user_cloud_policy_store_base.cc
index 46dffc220e5ff5553beff073019de168ffca0754..bca28896ed9c804b6a6e93f99e5e12abdeb4abc1 100644
--- a/components/policy/core/common/cloud/user_cloud_policy_store_base.cc
+++ b/components/policy/core/common/cloud/user_cloud_policy_store_base.cc
@@ -31,8 +31,9 @@ UserCloudPolicyStoreBase::CreateValidator(
std::unique_ptr<enterprise_management::PolicyFetchResponse> policy,
CloudPolicyValidatorBase::ValidateTimestampOption timestamp_option) {
// Configure the validator.
- UserCloudPolicyValidator* validator = UserCloudPolicyValidator::Create(
- std::move(policy), background_task_runner_);
+ std::unique_ptr<UserCloudPolicyValidator> validator =
+ UserCloudPolicyValidator::Create(std::move(policy),
+ background_task_runner_);
validator->ValidatePolicyType(dm_protocol::kChromeUserPolicyType);
validator->ValidateAgainstCurrentPolicy(
policy_.get(),
@@ -40,7 +41,7 @@ UserCloudPolicyStoreBase::CreateValidator(
CloudPolicyValidatorBase::DM_TOKEN_REQUIRED,
CloudPolicyValidatorBase::DEVICE_ID_REQUIRED);
validator->ValidatePayload();
- return std::unique_ptr<UserCloudPolicyValidator>(validator);
+ return validator;
}
void UserCloudPolicyStoreBase::InstallPolicy(

Powered by Google App Engine
This is Rietveld 408576698