Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: components/policy/core/common/cloud/cloud_policy_validator.cc

Issue 2817643002: Make CloudPolicyValidator memory management clearer (Closed)
Patch Set: Cleaner memory management in CloudPolicyValidator Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/cloud_policy_validator.cc
diff --git a/components/policy/core/common/cloud/cloud_policy_validator.cc b/components/policy/core/common/cloud/cloud_policy_validator.cc
index ff6008def367ed6d93f4b3eb54724b59d63df632..3ac136b7cd6c4dc3e58038eb409f4adea49672c6 100644
--- a/components/policy/core/common/cloud/cloud_policy_validator.cc
+++ b/components/policy/core/common/cloud/cloud_policy_validator.cc
@@ -185,13 +185,16 @@ CloudPolicyValidatorBase::CloudPolicyValidatorBase(
DCHECK(!verification_key_.empty());
}
+// static
void CloudPolicyValidatorBase::PostValidationTask(
+ std::unique_ptr<CloudPolicyValidatorBase> validator,
const base::Closure& completion_callback) {
- background_task_runner_->PostTask(
+ const auto task_runner = validator->background_task_runner_;
+ task_runner->PostTask(
FROM_HERE,
base::Bind(&CloudPolicyValidatorBase::PerformValidation,
- base::Passed(std::unique_ptr<CloudPolicyValidatorBase>(this)),
- base::ThreadTaskRunnerHandle::Get(), completion_callback));
+ base::Passed(&validator), base::ThreadTaskRunnerHandle::Get(),
+ completion_callback));
}
// static

Powered by Google App Engine
This is Rietveld 408576698