Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: chrome/browser/chromeos/settings/session_manager_operation.cc

Issue 2817643002: Make CloudPolicyValidator memory management clearer (Closed)
Patch Set: Cleaner memory management in CloudPolicyValidator Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/session_manager_operation.cc
diff --git a/chrome/browser/chromeos/settings/session_manager_operation.cc b/chrome/browser/chromeos/settings/session_manager_operation.cc
index ed847589209fa0736305c5404076c0db125bdf0a..bdd59b682604b57aaa68928efe06238c1b53b84c 100644
--- a/chrome/browser/chromeos/settings/session_manager_operation.cc
+++ b/chrome/browser/chromeos/settings/session_manager_operation.cc
@@ -165,9 +165,8 @@ void SessionManagerOperation::ValidateDeviceSettings(
base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
std::unique_ptr<policy::DeviceCloudPolicyValidator> validator =
- base::WrapUnique<policy::DeviceCloudPolicyValidator>(
- policy::DeviceCloudPolicyValidator::Create(std::move(policy),
- background_task_runner));
+ policy::DeviceCloudPolicyValidator::Create(std::move(policy),
+ background_task_runner);
if (cloud_validations_) {
// Policy auto-generated by session manager doesn't include a timestamp, so
@@ -206,8 +205,8 @@ void SessionManagerOperation::ValidateDeviceSettings(
validator->RunValidation();
ReportValidatorStatus(validator.get());
} else {
- // The Validator will delete itself once validation is complete.
- validator.release()->StartValidation(
+ policy::DeviceCloudPolicyValidator::StartValidation(
+ std::move(validator),
base::Bind(&SessionManagerOperation::ReportValidatorStatus,
weak_factory_.GetWeakPtr()));
}

Powered by Google App Engine
This is Rietveld 408576698