Remove ListValue::Append(raw ptr) on Mac and iOS

components/policy/core/common/mac_util_unittest.cc

Index: components/policy/core/common/mac_util_unittest.cc
diff --git a/components/policy/core/common/mac_util_unittest.cc b/components/policy/core/common/mac_util_unittest.cc
index c25610b0a32ed14fb01f6bc13039e393df317d5f..682f93de5d42288b40bc3e40e04325c307c22ada 100644
--- a/components/policy/core/common/mac_util_unittest.cc
+++ b/components/policy/core/common/mac_util_unittest.cc
@@ -40,18 +40,18 @@ TEST(PolicyMacUtilTest, PropertyToValue) {
 
   // base::Value::Type::LIST
   base::ListValue list;
-  root.Set("emptyl", list.DeepCopy());
+  root.Set("emptyl", base::MakeUnique<base::Value>(list));

[jdoerrie, 2017/04/12 12:37:46]

Given that list is empty, you can simply use

root.Set("emptyl", base::MakeUnique<base::ListValue>());

or the more verbose

root.Set("emptyl", base::MakeUnique<base::Value>(base::Value::Type::LIST));

instead and declare list below after.

[vabr (Chromium), 2017/04/12 12:55:03]

Done.

   for (base::DictionaryValue::Iterator it(root); !it.IsAtEnd(); it.Advance())
-    list.Append(it.value().DeepCopy());
+    list.Append(base::MakeUnique<base::Value>(it.value()));
   EXPECT_EQ(root.size(), list.GetSize());
-  list.Append(root.DeepCopy());
-  root.Set("list", list.DeepCopy());
+  list.Append(base::MakeUnique<base::Value>(root));
+  root.Set("list", base::MakeUnique<base::Value>(list));
 
   // base::Value::Type::DICTIONARY
   base::DictionaryValue dict;
-  root.Set("emptyd", dict.DeepCopy());
+  root.Set("emptyd", base::MakeUnique<base::Value>(dict));

[jdoerrie, 2017/04/12 12:37:46]

root.Set("emptyd", base::MakeUnique<base::DictionaryValue>());

or

root.Set("dict", base::MakeUnique<base::Value>(base::Value::Type::DICTIONARY));

[vabr (Chromium), 2017/04/12 12:55:03]

Done.

   // Very meta.
-  root.Set("dict", root.DeepCopy());
+  root.Set("dict", base::MakeUnique<base::Value>(root));
 
   base::ScopedCFTypeRef<CFPropertyListRef> property(ValueToProperty(root));
   ASSERT_TRUE(property);