Remove ListValue::Append(raw ptr) on Mac and iOS

ios/chrome/browser/passwords/password_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/passwords/password_controller.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <map>
 #include <memory>
 #include <utility>
 #include <vector>
 
 #import "base/ios/weak_nsobject.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"

[jdoerrie, 2017/04/12 12:37:46]

#include "base/values.h"

[vabr (Chromium), 2017/04/12 12:55:04]

Done.

 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/infobars/core/infobar_manager.h"
 #include "components/password_manager/core/browser/password_bubble_experiment.h"
 #include "components/password_manager/core/browser/password_generation_manager.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "components/password_manager/core/browser/password_manager_client.h"
 #include "components/password_manager/core/browser/password_manager_driver.h"
 #include "components/sync/driver/sync_service.h"
@@ skipping 179 matching lines @@
   rootDict.SetString("action", formData.action.spec());
 
   // Input elements in the form. The list does not necessarily contain
   // all elements from the form, but all elements listed here are required
   // to identify the right form to fill.
   auto fieldList = base::MakeUnique<base::ListValue>();
 
   auto usernameField = base::MakeUnique<base::DictionaryValue>();
   usernameField->SetString("name", formData.username_field.name);
   usernameField->SetString("value", formData.username_field.value);
-  fieldList->Append(usernameField.release());
+  fieldList->Append(std::move(usernameField));
 
   auto passwordField = base::MakeUnique<base::DictionaryValue>();
   passwordField->SetString("name", formData.password_field.name);
   passwordField->SetString("value", formData.password_field.value);
-  fieldList->Append(passwordField.release());
+  fieldList->Append(std::move(passwordField));
 
-  rootDict.Set("fields", fieldList.release());
+  rootDict.Set("fields", std::move(fieldList));
 
   std::string jsonString;
   base::JSONWriter::Write(rootDict, &jsonString);
   return base::SysUTF8ToNSString(jsonString);
 }
 
 // Returns true if the trust level for the current page URL of |web_state| is
 // kAbsolute. If |page_url| is not null, fills it with the current page URL.
 bool GetPageURLAndCheckTrustLevel(web::WebState* web_state, GURL* page_url) {
   auto trustLevel = web::URLVerificationTrustLevel::kNone;
@@ skipping 633 matching lines @@
       break;
 
     case PasswordInfoBarType::UPDATE:
       IOSChromeUpdatePasswordInfoBarDelegate::Create(
           isSmartLockBrandingEnabled, infoBarManager, std::move(form));
       break;
   }
 }
 
 @end