Remove ListValue::Append(raw ptr) on Mac and iOS

content/common/font_list_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/font_list.h"
 
 #import <Cocoa/Cocoa.h>
 
+#include <utility>
+
 #include "base/mac/scoped_nsautorelease_pool.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/values.h"
 
 namespace content {
 
 std::unique_ptr<base::ListValue> GetFontList_SlowBlocking() {
   base::mac::ScopedNSAutoreleasePool autorelease_pool;
   std::unique_ptr<base::ListValue> font_list(new base::ListValue);
   NSFontManager* fontManager = [[[NSFontManager alloc] init] autorelease];
   NSMutableDictionary* fonts_dict = [NSMutableDictionary dictionary];
   NSArray* fonts = [fontManager availableFontFamilies];
 
   for (NSString* family_name in fonts) {
     NSString* localized_family_name =
         [fontManager localizedNameForFamily:family_name face:nil];
     fonts_dict[family_name] = localized_family_name;
   }
 
   // Sort family names based on localized names.
   NSArray* sortedFonts = [fonts_dict
       keysSortedByValueUsingSelector:@selector(localizedStandardCompare:)];
 
   for (NSString* family_name in sortedFonts) {
     NSString* localized_family_name = fonts_dict[family_name];
-    base::ListValue* font_item = new base::ListValue();
+    auto font_item = base::MakeUnique<base::ListValue>();
     base::string16 family = base::SysNSStringToUTF16(family_name);
     base::string16 loc_family = base::SysNSStringToUTF16(localized_family_name);
-    font_item->Append(new base::Value(family));
-    font_item->Append(new base::Value(loc_family));
-    font_list->Append(font_item);
+    font_item->Append(base::MakeUnique<base::Value>(family));
+    font_item->Append(base::MakeUnique<base::Value>(loc_family));

[jdoerrie, 2017/04/12 12:37:46]

Consider the more compact AppendString, ie:

font_item->AppendString(family);
font_item->AppendString(loc_family);

[vabr (Chromium), 2017/04/12 12:55:04]

Good point, I completely missed the existence of those convenience methods.
Thanks!

+    font_list->Append(std::move(font_item));
   }
 
   return font_list;
 }
 
 }  // namespace content