Remove ListValue::Append(raw ptr) on Mac and iOS

content/browser/accessibility/accessibility_tree_formatter_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/accessibility_tree_formatter.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/files/file_path.h"
 #include "base/json/json_writer.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"

[jdoerrie, 2017/04/12 12:37:46]

#include "base/values.h"

[vabr (Chromium), 2017/04/12 12:55:04]

Done.

 #include "content/browser/accessibility/browser_accessibility_cocoa.h"
 #include "content/browser/accessibility/browser_accessibility_mac.h"
 #include "content/browser/accessibility/browser_accessibility_manager.h"
 
 using base::StringPrintf;
 using base::SysNSStringToUTF8;
 using base::SysNSStringToUTF16;
 using std::string;
 
 namespace content {
@@ skipping 56 matching lines @@
   if (![value isKindOfClass:[NSValue class]])
     return false;
   return 0 == strcmp([value objCType], @encode(NSRange));
 }
 
 std::unique_ptr<base::Value> PopulateObject(id value);
 
 std::unique_ptr<base::ListValue> PopulateArray(NSArray* array) {
   std::unique_ptr<base::ListValue> list(new base::ListValue);
   for (NSUInteger i = 0; i < [array count]; i++)
-    list->Append(PopulateObject([array objectAtIndex:i]).release());
+    list->Append(PopulateObject([array objectAtIndex:i]));
   return list;
 }
 
 std::unique_ptr<base::Value> StringForBrowserAccessibility(
     BrowserAccessibilityCocoa* obj) {
   NSMutableArray* tokens = [[NSMutableArray alloc] init];
 
   // Always include the role
   id role = [obj role];
   [tokens addObject:role];
@@ skipping 144 matching lines @@
   }
 
   CR_DEFINE_STATIC_LOCAL(NSArray*, all_attributes, (BuildAllAttributesArray()));
   for (NSString* requestedAttribute in all_attributes) {
     if (![supportedAttributes containsObject:requestedAttribute])
       continue;
     id value = [cocoa_node accessibilityAttributeValue:requestedAttribute];
     if (value != nil) {
       dict->Set(
           SysNSStringToUTF8(requestedAttribute),
-          PopulateObject(value).release());
+          PopulateObject(value));
     }
   }
-  dict->Set(kPositionDictAttr, PopulatePosition(node).release());
-  dict->Set(kSizeDictAttr, PopulateSize(cocoa_node).release());
+  dict->Set(kPositionDictAttr, PopulatePosition(node));
+  dict->Set(kSizeDictAttr, PopulateSize(cocoa_node));
 }
 
 base::string16 AccessibilityTreeFormatterMac::ToString(
     const base::DictionaryValue& dict) {
   base::string16 line;
   if (show_ids()) {
     int id_value;
     dict.GetInteger("id", &id_value);
     WriteAttribute(true, base::IntToString16(id_value), &line);
   }
@@ skipping 69 matching lines @@
 
 const string AccessibilityTreeFormatterMac::GetAllowString() {
   return "@MAC-ALLOW:";
 }
 
 const string AccessibilityTreeFormatterMac::GetDenyString() {
   return "@MAC-DENY:";
 }
 
 }  // namespace content