Remove ListValue::Append(raw ptr) on Mac and iOS

components/wifi/wifi_service_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/wifi/wifi_service.h"
 
 #import <CoreWLAN/CoreWLAN.h>
 #import <netinet/in.h>
 #import <SystemConfiguration/SystemConfiguration.h>
 
+#include <utility>
+
 #include "base/bind.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"

[jdoerrie, 2017/04/12 12:37:46]

#include "base/values.h"

[vabr (Chromium), 2017/04/12 12:55:04]

Done.

 #include "base/strings/sys_string_conversions.h"
 #include "components/onc/onc_constants.h"
 #include "components/wifi/network_properties.h"
 #include "crypto/apple_keychain.h"
 
 namespace wifi {
 
 // Implementation of WiFiService for Mac OS X.
 class WiFiServiceMac : public WiFiService {
  public:
@@ skipping 229 matching lines @@
   }
 
   if (networks_.empty())
     UpdateNetworks();
 
   for (NetworkList::const_iterator it = networks_.begin();
        it != networks_.end();
        ++it) {
     std::unique_ptr<base::DictionaryValue> network(
         it->ToValue(!include_details));
-    network_list->Append(network.release());
+    network_list->Append(std::move(network));
   }
 }
 
 void WiFiServiceMac::RequestNetworkScan() {
   DVLOG(1) << "*** RequestNetworkScan";
   UpdateNetworks();
 }
 
 void WiFiServiceMac::StartConnect(const std::string& network_guid,
                                   std::string* error) {
@@ skipping 336 matching lines @@
   DVLOG(1) << "NotifyNetworkChanged: " << network_guid;
   NetworkGuidList changed_networks(1, network_guid);
   event_task_runner_->PostTask(
       FROM_HERE, base::Bind(networks_changed_observer_, changed_networks));
 }
 
 // static
 WiFiService* WiFiService::Create() { return new WiFiServiceMac(); }
 
 }  // namespace wifi