Remove ListValue::Append(raw ptr) on Mac and iOS

components/wifi/fake_wifi_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/wifi/fake_wifi_service.h"
 
 #include <memory>
+#include <utility>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"

[jdoerrie, 2017/04/12 12:37:46]

#include "base/values.h"

[vabr (Chromium), 2017/04/12 12:55:03]

Done.

 #include "components/onc/onc_constants.h"
 
 namespace wifi {
 
 FakeWiFiService::FakeWiFiService() {
   // Populate data expected by unit test.
   {
     NetworkProperties network_properties;
     network_properties.connection_state = onc::connection_state::kConnected;
     network_properties.guid = "stub_wifi1_guid";
@@ skipping 90 matching lines @@
 void FakeWiFiService::GetVisibleNetworks(const std::string& network_type,
                                          base::ListValue* network_list,
                                          bool include_details) {
   for (NetworkList::const_iterator it = networks_.begin();
        it != networks_.end();
        ++it) {
     if (network_type.empty() || network_type == onc::network_type::kAllTypes ||
         it->type == network_type) {
       std::unique_ptr<base::DictionaryValue> network(
           it->ToValue(!include_details));
-      network_list->Append(network.release());
+      network_list->Append(std::move(network));
     }
   }
 }
 
 void FakeWiFiService::RequestNetworkScan() {
   NotifyNetworkListChanged(networks_);
 }
 
 void FakeWiFiService::StartConnect(const std::string& network_guid,
                                    std::string* error) {
@@ skipping 81 matching lines @@
       FROM_HERE, base::Bind(network_list_changed_observer_, current_networks));
 }
 
 void FakeWiFiService::NotifyNetworkChanged(const std::string& network_guid) {
   WiFiService::NetworkGuidList changed_networks(1, network_guid);
   task_runner_->PostTask(
       FROM_HERE, base::Bind(networks_changed_observer_, changed_networks));
 }
 
 }  // namespace wifi