Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2817553005: Try work around issues executing powershell scripts on windows on the bots (Closed)

Created:
3 years, 8 months ago by kustermann
Modified:
3 years, 8 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Try work around issues executing powershell scripts on windows on the bots R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/0de8c02b6cab2676088369c79afe933375138a86

Patch Set 1 #

Total comments: 2

Patch Set 2 : Try work around issues executing powershell scripts on windows on the bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/testing/dart/browser_controller.dart View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kustermann
3 years, 8 months ago (2017-04-12 10:23:21 UTC) #2
ricow1
https://codereview.chromium.org/2817553005/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/2817553005/diff/1/tools/testing/dart/browser_controller.dart#newcode1913 tools/testing/dart/browser_controller.dart:1913: '-File ', nit: remove space after -File?
3 years, 8 months ago (2017-04-12 10:25:42 UTC) #3
kustermann
Thanks https://codereview.chromium.org/2817553005/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/2817553005/diff/1/tools/testing/dart/browser_controller.dart#newcode1913 tools/testing/dart/browser_controller.dart:1913: '-File ', On 2017/04/12 10:25:42, ricow1 wrote: > ...
3 years, 8 months ago (2017-04-12 10:27:00 UTC) #4
ricow1
lgtm
3 years, 8 months ago (2017-04-12 10:27:20 UTC) #5
kustermann
3 years, 8 months ago (2017-04-12 10:28:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0de8c02b6cab2676088369c79afe933375138a86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698