Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp
index b4669d8ca6ea2d2373f3cc7aac998e199587d52e..2391154f59477b3ae80ebd92a1080568e4e6d453 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp
@@ -63,11 +63,11 @@ unsigned V8NodeFilterCondition::AcceptNode(
Node* node,
ExceptionState& exception_state) const {
v8::Isolate* isolate = script_state_->GetIsolate();
- ASSERT(!script_state_->GetContext().IsEmpty());
+ DCHECK(!script_state_->GetContext().IsEmpty());
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Value> filter = filter_.NewLocal(isolate);
- ASSERT(filter.IsEmpty() || filter->IsObject());
+ DCHECK(filter.IsEmpty() || filter->IsObject());
if (filter.IsEmpty())
return NodeFilter::kFilterAccept;
@@ -120,7 +120,7 @@ unsigned V8NodeFilterCondition::AcceptNode(
return NodeFilter::kFilterReject;
}
- ASSERT(!result.IsEmpty());
+ DCHECK(!result.IsEmpty());
uint32_t uint32_value;
if (!V8Call(result->Uint32Value(script_state_->GetContext()), uint32_value,

Powered by Google App Engine
This is Rietveld 408576698