third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h b/third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h

index 9df6c7b166a58a11f040c0b756124086c91f3e31..f92ca96a6346977a4f532aeddb4eaf8b5baa71ca 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h

@@ -59,7 +59,7 @@ class V8IdleTaskRunner : public gin::V8IdleTaskRunner {

V8IdleTaskRunner(WebScheduler* scheduler) : scheduler_(scheduler) {}

~V8IdleTaskRunner() override {}

void PostIdleTask(v8::IdleTask* task) override {

- ASSERT(RuntimeEnabledFeatures::v8IdleTasksEnabled());

+ DCHECK(RuntimeEnabledFeatures::v8IdleTasksEnabled());

scheduler_->PostIdleTask(BLINK_FROM_HERE, new V8IdleTaskAdapter(task));

}