Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
index 94f6ba3e1a352ea1362293eca400268eb35783c9..56499fd40767c395bba343b323d85a05fdb1b68f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
@@ -81,9 +81,9 @@ inline void V8DOMWrapper::SetNativeInfo(
v8::Local<v8::Object> wrapper,
const WrapperTypeInfo* wrapper_type_info,
ScriptWrappable* script_wrappable) {
- ASSERT(wrapper->InternalFieldCount() >= 2);
- ASSERT(script_wrappable);
- ASSERT(wrapper_type_info);
+ DCHECK_GE(wrapper->InternalFieldCount(), 2);
+ DCHECK(script_wrappable);
+ DCHECK(wrapper_type_info);
int indices[] = {kV8DOMWrapperObjectIndex, kV8DOMWrapperTypeIndex};
void* values[] = {script_wrappable,
const_cast<WrapperTypeInfo*>(wrapper_type_info)};
@@ -115,7 +115,7 @@ inline v8::Local<v8::Object> V8DOMWrapper::AssociateObjectWithWrapper(
if (DOMDataStore::SetWrapper(isolate, impl, wrapper_type_info, wrapper)) {
wrapper_type_info->WrapperCreated();
SetNativeInfo(isolate, wrapper, wrapper_type_info, impl);
- ASSERT(HasInternalFieldsSet(wrapper));
+ DCHECK(HasInternalFieldsSet(wrapper));
}
SECURITY_CHECK(ToScriptWrappable(wrapper) == impl);
return wrapper;
@@ -136,7 +136,7 @@ class V8WrapperInstantiationScope {
// creationContext should not be empty. Because if we have an
// empty creationContext, we will end up creating
// a new object in the context currently entered. This is wrong.
- RELEASE_ASSERT(!creation_context.IsEmpty());
+ CHECK(!creation_context.IsEmpty());
v8::Local<v8::Context> context_for_wrapper =
creation_context->CreationContext();

Powered by Google App Engine
This is Rietveld 408576698