third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h b/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h

index 28af46d4876348f5dc27e19880fde50d243aed8b..d58ff2653ba9cf4f6667046b5ce3473f3fcebbbb 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h

@@ -82,7 +82,7 @@ inline bool V8Call(v8::Maybe<T> maybe,

T& out_variable,

v8::TryCatch& try_catch) {

bool success = V8Call(maybe, out_variable);

- ASSERT(success || try_catch.HasCaught());

+ DCHECK(success || try_catch.HasCaught());

return success;

}

@@ -98,7 +98,7 @@ inline bool V8Call(v8::MaybeLocal<T> maybe_local,

v8::Local<T>& out_variable,

v8::TryCatch& try_catch) {

bool success = maybe_local.ToLocal(&out_variable);

- ASSERT(success || try_catch.HasCaught());

+ DCHECK(success || try_catch.HasCaught());

return success;

}