Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp
index a81fa4cb5def22303f111bc878b6ea6645f14e63..ccaaed75e07a4eeb248b49bbd5916eea5064ad5e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp
@@ -63,7 +63,7 @@ V8AbstractEventListener::V8AbstractEventListener(bool is_attribute,
}
V8AbstractEventListener::~V8AbstractEventListener() {
- ASSERT(listener_.IsEmpty());
+ DCHECK(listener_.IsEmpty());
if (IsMainThread())
InstanceCounters::DecrementCounter(
InstanceCounters::kJSEventListenerCounter);
@@ -80,7 +80,7 @@ void V8AbstractEventListener::handleEvent(ExecutionContext* execution_context,
// A ScriptState used by the event listener needs to be calculated based on
// the ExecutionContext that fired the the event listener and the world
// that installed the event listener.
- ASSERT(event);
+ DCHECK(event);
v8::HandleScope handle_scope(ToIsolate(execution_context));
v8::Local<v8::Context> v8_context = ToV8Context(execution_context, World());
if (v8_context.IsEmpty())
@@ -106,7 +106,7 @@ void V8AbstractEventListener::HandleEvent(ScriptState* script_state,
void V8AbstractEventListener::SetListenerObject(
v8::Local<v8::Object> listener) {
- ASSERT(listener_.IsEmpty());
+ DCHECK(listener_.IsEmpty());
// Balanced in wrapperCleared xor clearListenerObject.
if (worker_global_scope_) {
worker_global_scope_->RegisterEventListener(this);

Powered by Google App Engine
This is Rietveld 408576698