third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp

index 6d36f4b6e14dd3229df9b34f73caca632ad84db6..bf2ee60244b978cdf2331408566deb0e8b4b16ad 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp

@@ -44,7 +44,7 @@ std::unique_ptr<V0CustomElementBinding> V0CustomElementBinding::Create(

V0CustomElementBinding::V0CustomElementBinding(v8::Isolate* isolate,

v8::Local<v8::Object> prototype)

: prototype_(isolate, prototype) {

- ASSERT(!prototype_.IsEmpty());

+ DCHECK(!prototype_.IsEmpty());

}

V0CustomElementBinding::~V0CustomElementBinding() {}