third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

index dd66b7a97845de7ed54075e9375a093857a8d54c..70e433ef99afda336333a3bd3a7007bcd9992a8d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

@@ -32,7 +32,7 @@ class Function : public ScriptFunction {

: ScriptFunction(script_state), value_(value) {}

ScriptValue Call(ScriptValue value) override {

- ASSERT(!value.IsEmpty());

+ DCHECK(!value.IsEmpty());

*value_ = ToCoreString(value.V8Value()

->ToString(GetScriptState()->GetContext())

.ToLocalChecked());