third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

index 30fa530c8005048c80e6e64aaf9c25d24272b696..3cf4a77736902ef759a60f243e4aaf456ecf5ea0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

@@ -86,7 +86,7 @@ v8::Local<v8::Value> V8LazyEventListener::CallListenerFunction(

ScriptState* script_state,

v8::Local<v8::Value> js_event,

Event* event) {

- ASSERT(!js_event.IsEmpty());

+ DCHECK(!js_event.IsEmpty());

v8::Local<v8::Object> listener_object =

GetListenerObject(script_state->GetExecutionContext());

if (listener_object.IsEmpty())