Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
index 249080d68e506246e613dcc04512f5399433f5be..ed4debaa45392b0ad3f36ea41d4b49b99e57906b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
@@ -46,7 +46,7 @@ v8::Local<v8::Object> V8DOMWrapper::CreateWrapper(
v8::Isolate* isolate,
v8::Local<v8::Object> creation_context,
const WrapperTypeInfo* type) {
- ASSERT(!type->Equals(&V8Window::wrapperTypeInfo));
+ DCHECK(!type->Equals(&V8Window::wrapperTypeInfo));
// According to
// https://html.spec.whatwg.org/multipage/browsers.html#security-location,
// cross-origin script access to a few properties of Location is allowed.
@@ -130,8 +130,8 @@ void V8WrapperInstantiationScope::SecurityCheck(
return;
}
const DOMWrapperWorld& current_world = DOMWrapperWorld::World(context_);
- RELEASE_ASSERT(current_world.GetWorldId() ==
- DOMWrapperWorld::World(context_for_wrapper).GetWorldId());
+ CHECK_EQ(current_world.GetWorldId(),
+ DOMWrapperWorld::World(context_for_wrapper).GetWorldId());
// TODO(jochen): Add the interface name here once this is generalized.
ExceptionState exception_state(isolate, ExceptionState::kConstructionContext,
nullptr);

Powered by Google App Engine
This is Rietveld 408576698