third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

index f1a933580c508f773c88e921109da57deee6f704..3cec37e8cda808b82c0009a042c3917b5caae47e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

@@ -57,7 +57,7 @@ void ScriptPromiseResolver::KeepAliveWhilePending() {

}

void ScriptPromiseResolver::OnTimerFired(TimerBase*) {

- ASSERT(state_ == kResolving || state_ == kRejecting);

+ DCHECK(state_ == kResolving || state_ == kRejecting);

if (!GetScriptState()->ContextIsValid()) {

Detach();

return;