Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
index 28053099b0518eb74396882749bac50cb4de0c4e..2d3cf204aed9d7599e0ab0db73747a86ec80b67f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
@@ -51,7 +51,7 @@ ScheduledAction* ScheduledAction::Create(ScriptState* script_state,
ExecutionContext* target,
const ScriptValue& handler,
const Vector<ScriptValue>& arguments) {
- ASSERT(handler.IsFunction());
+ DCHECK(handler.IsFunction());
if (!script_state->World().IsWorkerWorld()) {
if (!BindingSecurity::ShouldAllowAccessToFrame(
EnteredDOMWindow(script_state->GetIsolate()),
@@ -120,7 +120,7 @@ ScheduledAction::ScheduledAction(ScriptState* script_state,
: script_state_(script_state),
info_(script_state->GetIsolate()),
code_(String(), KURL(), TextPosition::BelowRangePosition()) {
- ASSERT(function.IsFunction());
+ DCHECK(function.IsFunction());
function_.Set(script_state->GetIsolate(),
v8::Local<v8::Function>::Cast(function.V8Value()));
info_.ReserveCapacity(arguments.size());
@@ -174,7 +174,7 @@ void ScheduledAction::Execute(LocalFrame* frame) {
}
void ScheduledAction::Execute(WorkerGlobalScope* worker) {
- ASSERT(worker->GetThread()->IsCurrentThread());
+ DCHECK(worker->GetThread()->IsCurrentThread());
if (!script_state_->ContextIsValid()) {
DVLOG(1) << "ScheduledAction::execute " << this << ": context is empty";

Powered by Google App Engine
This is Rietveld 408576698