Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (c) 2009, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 execution_context->IsContextDestroyed()) 47 execution_context->IsContextDestroyed())
48 return true; 48 return true;
49 if (!m_scriptState->ContextIsValid()) 49 if (!m_scriptState->ContextIsValid())
50 return true; 50 return true;
51 ScriptState::Scope scope(m_scriptState.Get()); 51 ScriptState::Scope scope(m_scriptState.Get());
52 52
53 v8::Local<v8::Value> transaction_handle = 53 v8::Local<v8::Value> transaction_handle =
54 ToV8(transaction, m_scriptState->GetContext()->Global(), isolate); 54 ToV8(transaction, m_scriptState->GetContext()->Global(), isolate);
55 v8::Local<v8::Value> error_handle = 55 v8::Local<v8::Value> error_handle =
56 ToV8(error, m_scriptState->GetContext()->Global(), isolate); 56 ToV8(error, m_scriptState->GetContext()->Global(), isolate);
57 ASSERT(transaction_handle->IsObject()); 57 DCHECK(transaction_handle->IsObject());
58 58
59 v8::Local<v8::Value> argv[] = {transaction_handle, error_handle}; 59 v8::Local<v8::Value> argv[] = {transaction_handle, error_handle};
60 60
61 v8::TryCatch exception_catcher(isolate); 61 v8::TryCatch exception_catcher(isolate);
62 exception_catcher.SetVerbose(true); 62 exception_catcher.SetVerbose(true);
63 63
64 v8::Local<v8::Value> result; 64 v8::Local<v8::Value> result;
65 // FIXME: This comment doesn't make much sense given what the code is actually 65 // FIXME: This comment doesn't make much sense given what the code is actually
66 // doing. 66 // doing.
67 // 67 //
68 // Step 6: If the error callback returns false, then move on to the next 68 // Step 6: If the error callback returns false, then move on to the next
69 // statement, if any, or onto the next overall step otherwise. Otherwise, 69 // statement, if any, or onto the next overall step otherwise. Otherwise,
70 // the error callback did not return false, or there was no error callback. 70 // the error callback did not return false, or there was no error callback.
71 // Jump to the last step in the overall steps. 71 // Jump to the last step in the overall steps.
72 if (!V8ScriptRunner::CallFunction(m_callback.NewLocal(isolate), 72 if (!V8ScriptRunner::CallFunction(m_callback.NewLocal(isolate),
73 ExecutionContext::From(m_scriptState.Get()), 73 ExecutionContext::From(m_scriptState.Get()),
74 m_scriptState->GetContext()->Global(), 74 m_scriptState->GetContext()->Global(),
75 WTF_ARRAY_LENGTH(argv), argv, isolate) 75 WTF_ARRAY_LENGTH(argv), argv, isolate)
76 .ToLocal(&result)) 76 .ToLocal(&result))
77 return true; 77 return true;
78 bool value; 78 bool value;
79 if (!result->BooleanValue(isolate->GetCurrentContext()).To(&value)) 79 if (!result->BooleanValue(isolate->GetCurrentContext()).To(&value))
80 return true; 80 return true;
81 return value; 81 return value;
82 } 82 }
83 83
84 } // namespace blink 84 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698