Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2014 Opera Software ASA. All rights reserved. 3 * Copyright (C) 2014 Opera Software ASA. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 return; 66 return;
67 67
68 V8SetReturnValue(info, value); 68 V8SetReturnValue(info, value);
69 } 69 }
70 70
71 template <typename ElementType> 71 template <typename ElementType>
72 void SetScriptableObjectProperty( 72 void SetScriptableObjectProperty(
73 const AtomicString& name, 73 const AtomicString& name,
74 v8::Local<v8::Value> value, 74 v8::Local<v8::Value> value,
75 const v8::PropertyCallbackInfo<v8::Value>& info) { 75 const v8::PropertyCallbackInfo<v8::Value>& info) {
76 ASSERT(!value.IsEmpty()); 76 DCHECK(!value.IsEmpty());
77 77
78 HTMLPlugInElement* impl = ElementType::toImpl(info.Holder()); 78 HTMLPlugInElement* impl = ElementType::toImpl(info.Holder());
79 RefPtr<SharedPersistent<v8::Object>> wrapper = impl->PluginWrapper(); 79 RefPtr<SharedPersistent<v8::Object>> wrapper = impl->PluginWrapper();
80 if (!wrapper) 80 if (!wrapper)
81 return; 81 return;
82 82
83 v8::Local<v8::Object> instance = wrapper->NewLocal(info.GetIsolate()); 83 v8::Local<v8::Object> instance = wrapper->NewLocal(info.GetIsolate());
84 84
85 if (instance.IsEmpty()) 85 if (instance.IsEmpty())
86 return; 86 return;
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 void V8HTMLObjectElement::namedPropertySetterCustom( 138 void V8HTMLObjectElement::namedPropertySetterCustom(
139 const AtomicString& name, 139 const AtomicString& name,
140 v8::Local<v8::Value> value, 140 v8::Local<v8::Value> value,
141 const v8::PropertyCallbackInfo<v8::Value>& info) { 141 const v8::PropertyCallbackInfo<v8::Value>& info) {
142 UseCounter::Count(CurrentExecutionContext(info.GetIsolate()), 142 UseCounter::Count(CurrentExecutionContext(info.GetIsolate()),
143 UseCounter::kHTMLObjectElementSetter); 143 UseCounter::kHTMLObjectElementSetter);
144 SetScriptableObjectProperty<V8HTMLObjectElement>(name, value, info); 144 SetScriptableObjectProperty<V8HTMLObjectElement>(name, value, info);
145 } 145 }
146 146
147 } // namespace blink 147 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698