Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 39
40 namespace blink { 40 namespace blink {
41 41
42 V8ErrorHandler::V8ErrorHandler(bool is_inline, ScriptState* script_state) 42 V8ErrorHandler::V8ErrorHandler(bool is_inline, ScriptState* script_state)
43 : V8EventListener(is_inline, script_state) {} 43 : V8EventListener(is_inline, script_state) {}
44 44
45 v8::Local<v8::Value> V8ErrorHandler::CallListenerFunction( 45 v8::Local<v8::Value> V8ErrorHandler::CallListenerFunction(
46 ScriptState* script_state, 46 ScriptState* script_state,
47 v8::Local<v8::Value> js_event, 47 v8::Local<v8::Value> js_event,
48 Event* event) { 48 Event* event) {
49 ASSERT(!js_event.IsEmpty()); 49 DCHECK(!js_event.IsEmpty());
50 if (!event->HasInterface(EventNames::ErrorEvent)) 50 if (!event->HasInterface(EventNames::ErrorEvent))
51 return V8EventListener::CallListenerFunction(script_state, js_event, event); 51 return V8EventListener::CallListenerFunction(script_state, js_event, event);
52 52
53 ErrorEvent* error_event = static_cast<ErrorEvent*>(event); 53 ErrorEvent* error_event = static_cast<ErrorEvent*>(event);
54 if (error_event->World() && error_event->World() != &World()) 54 if (error_event->World() && error_event->World() != &World())
55 return v8::Null(GetIsolate()); 55 return v8::Null(GetIsolate());
56 56
57 v8::Local<v8::Object> listener = 57 v8::Local<v8::Object> listener =
58 GetListenerObject(ExecutionContext::From(script_state)); 58 GetListenerObject(ExecutionContext::From(script_state));
59 if (listener.IsEmpty() || !listener->IsFunction()) 59 if (listener.IsEmpty() || !listener->IsFunction())
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 if (error->IsUndefined()) 130 if (error->IsUndefined())
131 return v8::Local<v8::Value>(); 131 return v8::Local<v8::Value>();
132 return error; 132 return error;
133 } 133 }
134 134
135 bool V8ErrorHandler::ShouldPreventDefault(v8::Local<v8::Value> return_value) { 135 bool V8ErrorHandler::ShouldPreventDefault(v8::Local<v8::Value> return_value) {
136 return return_value->IsBoolean() && return_value.As<v8::Boolean>()->Value(); 136 return return_value->IsBoolean() && return_value.As<v8::Boolean>()->Value();
137 } 137 }
138 138
139 } // namespace blink 139 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698