Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/RejectedPromises.h"
 
 #include <memory>
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ScriptValue.h"
@@ skipping 45 matching lines @@
     if (!execution_context)
       return;
 
     ScriptState::Scope scope(script_state_);
     v8::Local<v8::Value> value = promise_.NewLocal(script_state_->GetIsolate());
     v8::Local<v8::Value> reason =
         exception_.NewLocal(script_state_->GetIsolate());
     // Either collected or https://crbug.com/450330
     if (value.IsEmpty() || !value->IsPromise())
       return;
-    ASSERT(!HasHandler());
+    DCHECK(!HasHandler());
 
     EventTarget* target = execution_context->ErrorEventTarget();
     if (target && !execution_context->ShouldSanitizeScriptError(resource_name_,
                                                                 cors_status_)) {
       PromiseRejectionEventInit init;
       init.setPromise(ScriptPromise(script_state_, value));
       init.setReason(ScriptValue(script_state_, reason));
       init.setCancelable(true);
       PromiseRejectionEvent* event = PromiseRejectionEvent::Create(
           script_state_, EventTypeNames::unhandledrejection, init);
@@ skipping 43 matching lines @@
       ThreadDebugger* debugger =
           ThreadDebugger::From(script_state_->GetIsolate());
       if (debugger) {
         debugger->PromiseRejectionRevoked(script_state_->GetContext(),
                                           promise_rejection_id_);
       }
     }
   }
 
   void MakePromiseWeak() {
-    ASSERT(!promise_.IsEmpty() && !promise_.IsWeak());
+    DCHECK(!promise_.IsEmpty() && !promise_.IsWeak());

[tkent, 2017/04/13 05:37:16]

Split this into two DCHECKs.

DCHECK(!promise_.IsEmpty());
DCHECK(!promise_.IsWeak());

[bhagirathi.s, 2017/04/13 09:10:35]

Done.

     promise_.SetWeak(this, &Message::DidCollectPromise);
     exception_.SetWeak(this, &Message::DidCollectException);
   }
 
   void MakePromiseStrong() {
-    ASSERT(!promise_.IsEmpty() && promise_.IsWeak());
+    DCHECK(!promise_.IsEmpty() && promise_.IsWeak());

[tkent, 2017/04/13 05:37:16]

Ditto.

[bhagirathi.s, 2017/04/13 09:10:35]

Done.

     promise_.ClearWeak();
     exception_.ClearWeak();
   }
 
   bool HasHandler() {
-    ASSERT(!IsCollected());
+    DCHECK(!IsCollected());
     ScriptState::Scope scope(script_state_);
     v8::Local<v8::Value> value = promise_.NewLocal(script_state_->GetIsolate());
     return v8::Local<v8::Promise>::Cast(value)->HasHandler();
   }
 
  private:
   Message(ScriptState* script_state,
           v8::Local<v8::Promise> promise,
           v8::Local<v8::Value> exception,
           const String& error_message,
@@ skipping 126 matching lines @@
                                   kMaxReportedHandlersPendingResolution / 10);
     }
   }
 }
 
 void RejectedPromises::RevokeNow(std::unique_ptr<Message> message) {
   message->Revoke();
 }
 
 }  // namespace blink