ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.h - Issue 2817483002: [Workaround] Notify Overscroll Actions that a gesture ended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.h

Issue 2817483002: [Workaround] Notify Overscroll Actions that a gesture ended. (Closed)

Patch Set: Add back removeTarget, use weak protocol Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm ('k') | ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.h

diff --git a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.h b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.h

new file mode 100644

index 0000000000000000000000000000000000000000..67928d73b96ed73bf8a0d53d8e82056ca640da80

--- /dev/null

+++ b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.h

@@ -0,0 +1,18 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+#ifndef IOS_CHROME_BROWSER_UI_OVERSCROLL_ACTIONS_OVERSCROLL_ACTIONS_GESTURE_RECOGNIZER_H_

+#define IOS_CHROME_BROWSER_UI_OVERSCROLL_ACTIONS_OVERSCROLL_ACTIONS_GESTURE_RECOGNIZER_H_

+#import <UIKit/UIPanGestureRecognizer.h>

+// Subclass of UIPanGestureRecognizer that works around a bug where the targets'

+// action is not called when the gesture ends while "Speak selection" is

+// enabled (crbug.com/699655).

+// This subclass works around the bug by calling the action of the target passed

+// in the constructor when |reset| is called.

+@interface OverscrollActionsGestureRecognizer : UIPanGestureRecognizer

+@end

+#endif // IOS_CHROME_BROWSER_UI_OVERSCROLL_ACTIONS_OVERSCROLL_ACTIONS_GESTURE_RECOGNIZER_H_