ui/gfx/render_text_harfbuzz.cc - Issue 2817403002: [Omnibox] Elide omnibox text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2817403002: [Omnibox] Elide omnibox text (Closed)

Patch Set: Move line clearing to OnDisplayTextAttributeChanged Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index 18ee267ef34e619af2afca6b67513a449a577ca1..f883325a90b606cfc93d517ebc58a50c6674ba71 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -1180,6 +1180,8 @@ void RenderTextHarfBuzz::OnLayoutTextAttributeChanged(bool text_changed) {

void RenderTextHarfBuzz::OnDisplayTextAttributeChanged() {

update_display_text_ = true;

update_grapheme_iterator_ = true;

+ std::vector<internal::Line> empty_lines;

+ set_lines(&empty_lines);

}

void RenderTextHarfBuzz::EnsureLayout() {