[Omnibox] Elide omnibox text

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 6fc3b895ef0ba5c89f7e333c373d373a25bd902d..601f0a2c62abd65cb4d7e6006afae2ce91416b6b 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -139,6 +139,8 @@ void OmniboxViewViews::Init() {
   set_controller(this);
   SetTextInputType(ui::TEXT_INPUT_TYPE_URL);
 

[Peter Kasting, 2017/04/17 19:03:52]

Nit: Blank line here unnecessary

[simonhong, 2017/04/17 19:51:01]

Done.

+  GetRenderText()->SetElideBehavior(gfx::ELIDE_TAIL);
+
   if (popup_window_mode_)
     SetReadOnly(true);
 
@@ -749,6 +751,8 @@ bool OmniboxViewViews::HandleAccessibleAction(
 }
 
 void OmniboxViewViews::OnFocus() {
+  GetRenderText()->SetElideBehavior(gfx::NO_ELIDE);

[Peter Kasting, 2017/04/17 19:03:52]

Nit: Both here and in OnBlur() I'd attempt to call this after calling the
superclass handler, so the pattern is "run superclass handler, then do all local
handling"

[simonhong, 2017/04/17 19:51:01]

Done.

+
   views::Textfield::OnFocus();
   // TODO(oshima): Get control key state.
   model()->OnSetFocus(false);
@@ -766,6 +770,8 @@ void OmniboxViewViews::OnFocus() {
 }

[Peter Kasting, 2017/04/17 19:03:53]

Do we need to schedule a paint here or is changing the elide behavior guaranteed
to do that?

[simonhong, 2017/04/17 19:51:01]

It's guaranteed.
When getting text or properties from RenderText, RenderText ensure reflecting
new elide behavior to its text.

 
 void OmniboxViewViews::OnBlur() {
+  GetRenderText()->SetElideBehavior(gfx::ELIDE_TAIL);
+
   // Save the user's existing selection to restore it later.
   saved_selection_for_focus_change_ = GetSelectedRange();