Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2817403002: [Omnibox] Elide omnibox text (Closed)
Patch Set: Add comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index 18ee267ef34e619af2afca6b67513a449a577ca1..042986f882721ba5c7876a7342d650335558d941 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -1202,7 +1202,6 @@ void RenderTextHarfBuzz::EnsureLayout() {
ShapeRunList(display_text, display_run_list_.get());
}
update_display_run_list_ = false;
-
std::vector<internal::Line> empty_lines;
set_lines(&empty_lines);
}
@@ -1648,13 +1647,13 @@ void RenderTextHarfBuzz::EnsureLayoutRunList() {
ShapeRunList(text, &layout_run_list_);
}
- std::vector<internal::Line> empty_lines;
- set_lines(&empty_lines);
display_run_list_.reset();
update_display_text_ = true;
update_layout_run_list_ = false;
}
if (update_display_text_) {
+ std::vector<internal::Line> empty_lines;
+ set_lines(&empty_lines);
UpdateDisplayText(multiline() ? 0 : layout_run_list_.width());
update_display_text_ = false;
update_display_run_list_ = text_elided();
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698