[Omnibox] Elide omnibox text

ui/gfx/render_text_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 80 matching lines @@
   }
 
   const std::vector<BreakList<bool>>& styles() const {
     return render_text_->styles();
   }
 
   const std::vector<internal::Line>& lines() const {
     return render_text_->lines();
   }
 
+  void set_lines(std::vector<internal::Line>* lines) {
+    render_text_->set_lines(lines);
+  }
+
   SelectionModel EdgeSelectionModel(VisualCursorDirection direction) {
     return render_text_->EdgeSelectionModel(direction);
   }
 
   size_t TextIndexToDisplayIndex(size_t index) {
     return render_text_->TextIndexToDisplayIndex(index);
   }
 
   size_t DisplayIndexToTextIndex(size_t index) {
     return render_text_->DisplayIndexToTextIndex(index);
@@ skipping 4291 matching lines @@
 #endif
   const std::string font_name = "invalid_font";
   const int kFontSize = 13;
   RenderText* render_text = GetRenderText();
   render_text->SetFontList(FontList(Font(font_name, kFontSize)));
   render_text->SetText(ASCIIToUTF16("abc"));
 
   DrawVisualText();
 }
 
+TEST_P(RenderTextTest, LinesInvalidationOnElideBehaviorChange) {
+  RenderText* render_text = GetRenderText();
+  EXPECT_EQ(render_text->elide_behavior(), gfx::NO_ELIDE);
+
+  std::vector<internal::Line> lines(1);
+  test_api()->set_lines(&lines);

[msw, 2017/04/17 23:51:44]

nit: avoid adding RenderTextTestApi::set_lines and instead call
test_api()->EnsureLayout() to ensure we generate a valid Line struct; you might
need to call render_text->SetText() with some non-empty string first.

[simonhong, 2017/04/18 13:33:33]

Done.

+
+  render_text->SetElideBehavior(gfx::NO_ELIDE);
+  EXPECT_FALSE(test_api()->lines().empty());
+
+  // lines are cleared when elide behavior changes.

[msw, 2017/04/17 23:51:44]

nit: "Lines"

[simonhong, 2017/04/18 13:33:33]

Done.

+  render_text->SetElideBehavior(gfx::ELIDE_TAIL);
+  EXPECT_TRUE(test_api()->lines().empty());
+}
+
 // Ensures that text is centered vertically and consistently when either the
 // display rectangle height changes, or when the minimum line height changes.
 // The difference between the two is the selection rectangle, which should match
 // the line height.
 TEST_P(RenderTextHarfBuzzTest, BaselineWithLineHeight) {
   RenderText* render_text = GetRenderText();
   const int font_height = render_text->font_list().GetHeight();
   render_text->SetDisplayRect(Rect(500, font_height));
   render_text->SetText(ASCIIToUTF16("abc"));
 
@@ skipping 99 matching lines @@
                         ::testing::Values(RENDER_TEXT_HARFBUZZ),
                         PrintRenderTextBackend());
 #endif
 
 INSTANTIATE_TEST_CASE_P(,
                         RenderTextHarfBuzzTest,
                         ::testing::Values(RENDER_TEXT_HARFBUZZ),
                         PrintRenderTextBackend());
 
 }  // namespace gfx