tools/dom/src/dart2js_CustomElementSupport.dart - Issue 28173002: Code review changes for ngeoffray's comments on r28278

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/dart2js_CustomElementSupport.dart

Issue 28173002: Code review changes for ngeoffray's comments on r28278 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/html/dartium/html_dartium.dart ('K') | « tests/compiler/dart2js_native/subclassing_constructor_1_test.dart ('k') | tools/dom/templates/html/dart2js/html_dart2js.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/src/dart2js_CustomElementSupport.dart

diff --git a/tools/dom/src/dart2js_CustomElementSupport.dart b/tools/dom/src/dart2js_CustomElementSupport.dart

index 6f8aedb2e3352186ffb1583bd908cf845e8dc7df..39d40d105e5bbc4fcdb2f1228ecc13c14081aa3a 100644

--- a/tools/dom/src/dart2js_CustomElementSupport.dart

+++ b/tools/dom/src/dart2js_CustomElementSupport.dart

@@ -62,7 +62,7 @@ void _registerCustomElement(context, document, String tag, Type type,

throw new ArgumentError(type);

}

- var constructor = findConstructorForWebComponentType(type, 'created');

+ var constructor = findConstructorForNativeSubclassType(type, 'created');

if (constructor == null) {

throw new ArgumentError("$type has no constructor called 'created'");

}