sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 28173002: Code review changes for ngeoffray's comments on r28278

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 28173002: Code review changes for ngeoffray's comments on r28278 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/lib/interceptors.dart » ('j') | sdk/lib/html/dartium/html_dartium.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

index 0dff83395bea3f7e32a5c9b74d5c000d8d56daf6..abdfcd408435d93c332cb9b986c1273900fcd4d1 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

@@ -1796,8 +1796,7 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

List<js.Expression> arguments = visitArguments(node.inputs, start: 0);

// TODO(floitsch): jsClassReference is an Access. We shouldn't treat it

// as if it was a string.

- js.Expression constructor = new js.VariableUse(jsClassReference);

- push(new js.New(constructor, arguments), node);

+ push(new js.New(new js.VariableUse(jsClassReference), arguments), node);

registerForeignTypes(node);

if (node.instantiatedTypes == null) {

return;