sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart - Issue 28173002: Code review changes for ngeoffray's comments on r28278

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

Issue 28173002: Code review changes for ngeoffray's comments on r28278 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart b/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

index fe71b8699deccad71120ebd6be67c347f2e3d4dc..05511a282892c8832fef76fb31d5cdff9c1c892a 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

@@ -101,7 +101,7 @@ class CustomElementsAnalysis {

if (!fetchedTableAccessorMethod) {

fetchedTableAccessorMethod = true;

tableAccessorMethod = compiler.findInterceptor(

- const SourceString('findIndexForWebComponentType'));

+ const SourceString('findIndexForNativeSubclassType'));

}

if (element == tableAccessorMethod) {

joinFor(enqueuer).demanded = true;

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | sdk/lib/html/dartium/html_dartium.dart » ('J')