Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: ios/chrome/browser/tabs/tab.h

Issue 2817253002: Added |lastCommittedURL| and |visibleURL| to Tab's interface. (Closed)
Patch Set: returns => Returns Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_H_ 5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_H_
6 #define IOS_CHROME_BROWSER_TABS_TAB_H_ 6 #define IOS_CHROME_BROWSER_TABS_TAB_H_
7 7
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 : NSObject<CRWWebDelegate, ManageAccountsDelegate, SadTabTabHelperDelegate> 99 : NSObject<CRWWebDelegate, ManageAccountsDelegate, SadTabTabHelperDelegate>
100 100
101 // Browser state associated with this Tab. 101 // Browser state associated with this Tab.
102 @property(nonatomic, readonly) ios::ChromeBrowserState* browserState; 102 @property(nonatomic, readonly) ios::ChromeBrowserState* browserState;
103 103
104 // TODO(crbug.com/546208): Eliminate this; replace calls with either visible URL 104 // TODO(crbug.com/546208): Eliminate this; replace calls with either visible URL
105 // or last committed URL, depending on the specific use case. 105 // or last committed URL, depending on the specific use case.
106 // Do not add new calls to this method. 106 // Do not add new calls to this method.
107 @property(nonatomic, readonly) const GURL& url; 107 @property(nonatomic, readonly) const GURL& url;
108 108
109 // Returns the URL of the last committed NavigationItem for this Tab.
110 @property(nonatomic, readonly) const GURL& lastCommittedURL;
111
112 // Returns the URL of the visible NavigationItem for this Tab.
113 @property(nonatomic, readonly) const GURL& visibleURL;
114
109 // The Passkit Dialog provider used to show the UI to download a passkit object. 115 // The Passkit Dialog provider used to show the UI to download a passkit object.
110 @property(nonatomic, assign) id<PassKitDialogProvider> passKitDialogProvider; 116 @property(nonatomic, assign) id<PassKitDialogProvider> passKitDialogProvider;
111 117
112 // The current title of the tab. 118 // The current title of the tab.
113 @property(nonatomic, readonly) NSString* title; 119 @property(nonatomic, readonly) NSString* title;
114 120
115 // Original page title or nil if the page did not provide one. 121 // Original page title or nil if the page did not provide one.
116 @property(nonatomic, readonly) NSString* originalTitle; 122 @property(nonatomic, readonly) NSString* originalTitle;
117 123
118 @property(nonatomic, readonly) NSString* urlDisplayString; 124 @property(nonatomic, readonly) NSString* urlDisplayString;
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 // Evaluates U2F result. 305 // Evaluates U2F result.
300 - (void)evaluateU2FResultFromURL:(const GURL&)url; 306 - (void)evaluateU2FResultFromURL:(const GURL&)url;
301 307
302 // Cancels prerendering. It is an error to call this on anything except a 308 // Cancels prerendering. It is an error to call this on anything except a
303 // prerender tab (where |isPrerenderTab| is set to YES). 309 // prerender tab (where |isPrerenderTab| is set to YES).
304 - (void)discardPrerender; 310 - (void)discardPrerender;
305 311
306 @end 312 @end
307 313
308 #endif // IOS_CHROME_BROWSER_TABS_TAB_H_ 314 #endif // IOS_CHROME_BROWSER_TABS_TAB_H_
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698