Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5940)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js

Issue 2817243003: [MD settings] observe changes to default font size in Appearance (Closed)
Patch Set: nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
index ca60421a8af5ab38aa74b3548242434bacfdc9ed..f70b9e812b2e1bef83e609119cf8f81cdd2a7af8 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
@@ -5,13 +5,6 @@
(function() {
'use strict';
- /**
- * This is the absolute difference maintained between standard and
- * fixed-width font sizes. http://crbug.com/91922.
- * @const @private {number}
- */
- var SIZE_DIFFERENCE_FIXED_STANDARD_ = 3;
-
/** @const @private {!Array<number>} */
var FONT_SIZE_RANGE_ = [
9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 20, 22, 24, 26, 28, 30, 32, 34, 36,
@@ -26,11 +19,6 @@
/**
* 'settings-appearance-fonts-page' is the settings page containing appearance
* settings.
- *
- * Example:
- *
- * <settings-appearance-fonts-page prefs="{{prefs}}">
- * </settings-appearance-fonts-page>
*/
Polymer({
is: 'settings-appearance-fonts-page',
@@ -88,10 +76,6 @@
/** @private {?string} */
advancedExtensionUrl_: null,
- observers: [
- 'fontSizeChanged_(prefs.webkit.webprefs.default_font_size.value)',
- ],
-
/** @override */
created: function() {
this.browserProxy_ = settings.FontsBrowserProxyImpl.getInstance();
@@ -144,18 +128,6 @@
},
/**
- * @param {number} value The changed font size slider value.
- * @private
- */
- fontSizeChanged_: function(value) {
- // TODO(michaelpg): Whitelist this pref in prefs_utils.cc so it is
- // included in the <settings-prefs> getAllPrefs call, otherwise this path
- // is invalid and nothing happens. See crbug.com/612535.
- this.set('prefs.webkit.webprefs.default_fixed_font_size.value',
- value - SIZE_DIFFERENCE_FIXED_STANDARD_);
- },
-
- /**
* Get the minimum font size, accounting for unset prefs.
* @return {?}
* @private

Powered by Google App Engine
This is Rietveld 408576698