Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 281723008: [Telemetry] Speed up page cycler by another ~20%. (Closed)

Created:
6 years, 7 months ago by tonyg
Modified:
6 years, 7 months ago
Reviewers:
bulach
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Speed up page cycler by another ~20%. This reduces cycle time of one moz iteration from just under 4m to just over 3m. It assumes that pids won't be re-used, which isn't totally valid, but I think the chances of rolling over the pid space within a single benchmark is a low enough risk that we should do this. BUG=372489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
6 years, 7 months ago (2014-05-13 15:17:08 UTC) #1
bulach
lgtm, go for it! :)
6 years, 7 months ago (2014-05-13 15:26:01 UTC) #2
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 7 months ago (2014-05-13 15:41:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/281723008/1
6 years, 7 months ago (2014-05-13 15:42:09 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 17:42:51 UTC) #5
Message was sent while issue was closed.
Change committed as 270139

Powered by Google App Engine
This is Rietveld 408576698