Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 281723007: Remove socket implementation from V8. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove from cctest.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -469 lines) Patch
M src/platform-posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/platform/socket.h View 1 chunk +0 lines, -78 lines 0 comments Download
D src/platform/socket.cc View 1 chunk +0 lines, -201 lines 0 comments Download
M test/cctest/cctest.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-socket.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 7 months ago (2014-05-13 14:05:49 UTC) #1
Yang
On 2014/05/13 14:05:49, Yang wrote: This requires https://codereview.chromium.org/279423004/
6 years, 7 months ago (2014-05-13 14:06:31 UTC) #2
Jakob Kummerow
DBC: AFAICS this CL renders FlagDependentPortOffset() in cctest.h unused, so you can delete that too. ...
6 years, 7 months ago (2014-05-14 08:23:59 UTC) #3
Yang
On 2014/05/14 08:23:59, Jakob wrote: > DBC: AFAICS this CL renders FlagDependentPortOffset() in cctest.h unused, ...
6 years, 7 months ago (2014-05-14 08:26:51 UTC) #4
Yang
6 years, 7 months ago (2014-05-14 16:34:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698