Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/gn/escape.cc

Issue 2817223002: Remove base::StackString. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/containers/stack_container.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/escape.cc
diff --git a/tools/gn/escape.cc b/tools/gn/escape.cc
index 5f2752346467e8c440878a061a277fb480067b9f..cf119f24b7baae061f4a7a5747dae5d1df0e5757 100644
--- a/tools/gn/escape.cc
+++ b/tools/gn/escape.cc
@@ -6,7 +6,6 @@
#include <stddef.h>
-#include "base/containers/stack_container.h"
#include "base/logging.h"
#include "build/build_config.h"
@@ -202,8 +201,8 @@ std::string EscapeString(const base::StringPiece& str,
void EscapeStringToStream(std::ostream& out,
const base::StringPiece& str,
const EscapeOptions& options) {
- base::StackString<256> escaped;
- EscapeStringToString(str, options, &escaped.container(), nullptr);
- if (!escaped->empty())
- out.write(escaped->data(), escaped->size());
+ std::string escaped;
+ EscapeStringToString(str, options, &escaped, nullptr);
sunnyps 2017/04/14 17:27:54 EscapeStringToString and other methods don't need
+ if (!escaped.empty())
+ out.write(escaped.data(), escaped.size());
}
« no previous file with comments | « base/containers/stack_container.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698