Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2817113002: [Sync] Couple of random cleanups (Closed)

Created:
3 years, 8 months ago by pavely
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tfarina, sync-reviews_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Couple of random cleanups - SyncGlobalError is not used anymore - BackendMigrator::HasMigrationObserver is not called from anywhere - PerDataTypeAssociatorInterface is not used anywhere R=pnoland@chromium.org BUG= Review-Url: https://codereview.chromium.org/2817113002 Cr-Commit-Position: refs/heads/master@{#465001} Committed: https://chromium.googlesource.com/chromium/src/+/e54770e94d8afdd07a2d6bba62c317b023204cd0

Patch Set 1 #

Patch Set 2 : Remove PerDataTypeAssociatorInterface too #

Patch Set 3 : RemoveSyncNodeHierarchy is not called #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -493 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/sync/sync_global_error.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/sync/sync_global_error.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/sync/sync_global_error_factory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/sync/sync_global_error_factory.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 2 chunks +0 lines, -109 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/sync/driver/backend_migrator.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/backend_migrator.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/sync/driver/model_associator.h View 1 2 chunks +0 lines, -35 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.h View 1 2 3 chunks +6 lines, -13 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
pavely
3 years, 8 months ago (2017-04-14 00:25:16 UTC) #4
skym
lgtm
3 years, 8 months ago (2017-04-14 16:11:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817113002/40001
3 years, 8 months ago (2017-04-14 16:25:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/411581)
3 years, 8 months ago (2017-04-14 16:34:14 UTC) #16
pavely
Adding reviewers for files outside of sync. The changes are trivial, could you guys review: ...
3 years, 8 months ago (2017-04-14 17:40:49 UTC) #18
Peter Kasting
LGTM
3 years, 8 months ago (2017-04-14 18:17:43 UTC) #19
rohitrao (ping after 24h)
cocoa lgtm
3 years, 8 months ago (2017-04-14 18:24:34 UTC) #20
Mike Lerman
c/b/signin LGTM
3 years, 8 months ago (2017-04-17 18:51:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817113002/40001
3 years, 8 months ago (2017-04-17 19:23:15 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 20:30:47 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e54770e94d8afdd07a2d6bba62c3...

Powered by Google App Engine
This is Rietveld 408576698