Get maximum age of clipboard from clipboard_recent_contents.cc in iOS impl

components/open_from_clipboard/clipboard_recent_content_impl_ios.mm

Index: components/open_from_clipboard/clipboard_recent_content_impl_ios.mm
diff --git a/components/open_from_clipboard/clipboard_recent_content_impl_ios.mm b/components/open_from_clipboard/clipboard_recent_content_impl_ios.mm
index 669965ced16c4fa9ff7facfdd14c52765a14e340..9469002816fc594c6fb7700895f04b2a684ab000 100644
--- a/components/open_from_clipboard/clipboard_recent_content_impl_ios.mm
+++ b/components/open_from_clipboard/clipboard_recent_content_impl_ios.mm
@@ -26,8 +26,6 @@ NSString* const kPasteboardChangeDateKey = @"PasteboardChangeDate";
 // Key used to store the hash of the content of the pasteboard. Whenever the
 // hash changed, the pasteboard content is considered to have changed.
 NSString* const kPasteboardEntryMD5Key = @"PasteboardEntryMD5";
-// Maximum age of clipboard in seconds.
-NSTimeInterval const kMaximumAgeOfClipboard = 3 * 60 * 60;
 
 // Compute a hash consisting of the first 4 bytes of the MD5 hash of |string|.
 // This value is used to detect pasteboard content change. Keeping only 4 bytes
@@ -57,6 +55,8 @@ NSData* WeakMD5FromNSString(NSString* string) {
 @property(nonatomic, readonly) NSSet* authorizedSchemes;
 // Delegate for metrics.
 @property(nonatomic, strong) id<ClipboardRecentContentDelegate> delegate;
+// Maximum age of clipboard in seconds.
+@property(nonatomic) NSTimeInterval maximumAgeOfClipboard;

[marq (ping after 24h), 2017/04/13 11:33:38]

readonly, if this is only set in the init and never changes for the lifetime of
the object?

[lody, 2017/04/13 11:47:37]

Done.

 
 // If the content of the pasteboard has changed, updates the change count,
 // change date, and md5 of the latest pasteboard entry if necessary.
@@ -85,13 +85,15 @@ NSData* WeakMD5FromNSString(NSString* string) {
 @synthesize sharedUserDefaults = _sharedUserDefaults;
 @synthesize authorizedSchemes = _authorizedSchemes;
 @synthesize delegate = _delegate;
+@synthesize maximumAgeOfClipboard = _maximumAgeOfClipboard;
 
-- (instancetype)initWithAuthorizedSchemes:(NSSet<NSString*>*)authorizedSchemes
-                             userDefaults:(NSUserDefaults*)groupUserDefaults
-                                 delegate:(id<ClipboardRecentContentDelegate>)
-                                              delegate {
+- (instancetype)initWithMaxAge:(NSTimeInterval)maxAge
+             authorizedSchemes:(NSSet<NSString*>*)authorizedSchemes
+                  userDefaults:(NSUserDefaults*)groupUserDefaults
+                      delegate:(id<ClipboardRecentContentDelegate>)delegate {
   self = [super init];
   if (self) {
+    _maximumAgeOfClipboard = maxAge;
     _delegate = delegate;
     _authorizedSchemes = authorizedSchemes;
     _sharedUserDefaults = groupUserDefaults;
@@ -150,7 +152,7 @@ NSData* WeakMD5FromNSString(NSString* string) {
 
 - (NSURL*)recentURLFromClipboard {
   [self updateIfNeeded];
-  if ([self clipboardContentAge] > kMaximumAgeOfClipboard) {
+  if ([self clipboardContentAge] > [self maximumAgeOfClipboard]) {

[marq (ping after 24h), 2017/04/13 11:33:38]

Nit: prefer dot notation (self.maximumAgeOfClipboard) for properties.

[lody, 2017/04/13 11:47:37]

Done.

     return nil;
   }
   return [self URLFromPasteboard];